RFR [11] 8207838: AArch64: Float registers incorrectly resture in JNI call
Andrew Dinn
adinn at redhat.com
Tue Aug 14 13:30:55 UTC 2018
On 14/08/18 13:47, Andrew Haley wrote:
> When we make a JNI call with several floating-point args they are
> pushed and then popped in the reverse order. The fix it trivial and
> obvious and affects AArch64 only.
>
> The patch also affects non-AArch64 targets only in that it adds a test
> for this case.
>
> OK for 11?
>
> https://bugs.openjdk.java.net/browse/JDK-8207838
>
> http://cr.openjdk.java.net/~fyang/8207838/webrev.00/
The fix looks good to me. However, since we are in rampdown phase two
[1] and about to enter release candidate phase [2] I believe you need to
justify getting it into 11 as per the Late-Enhancement Request Process
[3]. So, it needs to be P1 or p2 and have a suitable justification
provided in the JIRA.
[1] http://mail.openjdk.java.net/pipermail/jdk-dev/2018-July/001669.html
[2] http://mail.openjdk.java.net/pipermail/jdk-dev/2018-August/001803.html
[3] http://openjdk.java.net/jeps/3
regards,
Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
More information about the hotspot-runtime-dev
mailing list