RFR(S) 8206115 - Use shared macros for JavaClasses::compute_offsets and MetaspaceShared::serialize_well_known_classes

[Ioi Lam]

On 8/14/18 11:47 PM, Claes Redestad wrote:
> Hi,
>
>
> On 2018-08-15 06:37, Ioi Lam wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8206115
>> http://cr.openjdk.java.net/~iklam/jdk12/8206115_compute_offsets_macro.v01/ 
>>
>
> looks like a good cleanup to me.
>
>>
>> As I noted in the comments on this RFE, we already have a bug where
>> java_lang_Integer_IntegerCache was missing from
>> MetaspaceShared::serialize_well_known_classes.
>
> Interesting that this omission didn't affect behavior in any 
> observable way, or
> did it? 8209120 includes a test that tests that things behave as 
> expected, in a
> few trivial cases exhaustively.
>
Hi Claes,

Thanks for the review.

Lucikly the java_lang_Integer_IntegerCache::compute_offsets() call is 
necessary only during dump time. That offset is not used at run time, so 
we've dodged a bullet.

Anyway, the current way of setting up the archivable static fields is 
pretty hard to work with. I've modified it to a simple text table. See 
https://bugs.openjdk.java.net/browse/JDK-8209545

Thanks
- Ioi