RFR [S] 8209647 constantPoolHandle::constantPoolHandle(ConstantPool*) when precompiled header is disabled
Calvin Cheung
calvin.cheung at oracle.com
Fri Aug 17 21:28:31 UTC 2018
Hi Ioi,
fieldDescriptor.hpp:
49 FieldInfo* field() const;
fieldDescriptor.inline.hpp:
49 inline FieldInfo* fieldDescriptor::field() const {
Should the function be declared inline in fieldDescriptor.hpp?
thanks,
Calvin
On 8/17/18, 1:30 PM, Ioi Lam wrote:
> https://bugs.openjdk.java.net/browse/JDK-8209647
> http://cr.openjdk.java.net/~iklam/jdk12/8209647-fieldDescriptor.inline.hpp.v02/
>
>
> PROBLEM:
>
> A few functions in the fieldDescriptor class, such as name(), use
> constantPoolHandle inline functions that are defined only in
> "runtime/handles.inline.hpp".
>
> FIX:
>
> fieldDescriptor.hpp is include precompiled.hpp, but we don't want to
> include
> handles.inline.hpp there. Therefore, we need to create a new
> fieldDescriptor.inline.hpp file to include the definitions of these
> functions.
>
> TESTING:
>
> I tested with both pch and no-pch builds for debug and release on Linux.
> Now I am running hs tiers 1 and 2 on mach5.
>
> Thanks
> - Ioi
More information about the hotspot-runtime-dev
mailing list