8209150: [TESTBUG] Add logging to verify JDK-8197901 to a different test

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Tue Aug 21 21:01:18 UTC 2018


Thank you, this is better!

http://cr.openjdk.java.net/~lmesnik/8209150/webrev.00/test/hotspot/jtreg/runtime/logging/RedefineClasses.java.html

   34  * @run main/othervm -Xmx256m -XX:MaxMetaspaceSize=64m -javaagent:redefineagent.jar -Xlog:all=trace:file=all.log RedefineClasses


 From this logging, did you verify that the output goes to all.log? I 
think the logging should be -Xlog:all=trace:all.log otherwise in the 
other test, I noticed it goes to the jtr file.

Also, the copyright should only be 2018.

Thanks,
Coleen

On 8/21/18 4:53 PM, Leonid Mesnik wrote:
> Hi
>
> Could you please review regression test for 8197901.
> I verified that test reproduce crash from  JDK-8197901 <https://bugs.openjdk.java.net/browse/JDK-8197901> if fix is not applied. Also this test is regression test for bug JDK-8209758 <https://bugs.openjdk.java.net/browse/JDK-8209758> which I found using it.
>
> I was unable to create simpler version which reproduce bug 8197901 since there is no good way to control when Klass:external_name is invoked while java_mirror is not correct.
>
> webrev: http://cr.openjdk.java.net/~lmesnik/8209150/webrev.00/ <http://cr.openjdk.java.net/~lmesnik/8209150/webrev.00/>
> bug: https://bugs.openjdk.java.net/browse/JDK-8209150 <https://bugs.openjdk.java.net/browse/JDK-8209150>
>
> Leonid



More information about the hotspot-runtime-dev mailing list