RFR 8202578: Revisit location for class unload events
Harold David Seigel
harold.seigel at oracle.com
Fri Aug 24 17:39:17 UTC 2018
Hi Coleen,
Thanks for reviewing this. I'll make the change that you describe below.
Harold
On 8/24/2018 12:32 PM, coleen.phillimore at oracle.com wrote:
>
> Harold, thank you for taking this.
>
> One small change:
>
> http://cr.openjdk.java.net/~hseigel/bug_8202578/webrev/src/hotspot/share/oops/instanceKlass.cpp.frames.html
>
>
> Also, can you put the definition from line 78 to inside of #ifdef JFR
> on line 2424. It shouldn't go with the #includes.
>
> I don't need to see another webrev for this. It looks really good.
>
> Thanks,
> Coleen
>
> On 8/23/18 6:55 PM, Harold David Seigel wrote:
>> Hi,
>>
>> Please review this fix for JDK-8202578. The fix enables posting of
>> JFR class unloading events without requiring a separate JFR-specific
>> iteration through the class loader data graph.
>>
>> Open Webrev:
>> http://cr.openjdk.java.net/~hseigel/bug_8202578/webrev/index.html
>>
>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8202578
>>
>> This fix was regression tested by running Mach5 tiers 1 and 2 tests
>> and builds on Linux-x64, Windows, and Mac OS X, running tiers 3-5
>> tests on Linux-x64, and by running JCK-11 Lang and VM tests on
>> Linux-x64. Additionally, the jdk JFR tests were run explicitly.
>>
>> Thanks, Harold
>>
>
More information about the hotspot-runtime-dev
mailing list