RFR 8209844: MemberNameLeak.java fails when ResolvedMethod entry is not removed

[Lois Foltan]

+1.  Looks good!
Lois

On 8/28/2018 6:13 PM, coleen.phillimore at oracle.com wrote:
>
> Looks really good!
>
> http://cr.openjdk.java.net/~pchilanomate/8209844.01/webrev/src/hotspot/share/prims/resolvedMethodTable.hpp.udiff.html 
>
>
> One small thing is that that field names are by convention preceded by 
> underscore:
>
> + static int total_oops_removed;
>
>
> Should be _total_oops_removed.
>
> Thanks for making the other counters local variables.
>
> Coleen
>
> On 8/28/18 5:52 PM, Patricio Chilano wrote:
>> Hi all,
>>
>> Could you review this change that addresses the intermittent failure 
>> of test MemberNameLeak.java after 8206423 ?
>> The test had intermittent failures due to the ServiceThread not being 
>> able to clean up the resolved method table before the process exited. 
>> Now a counter is used to guarantee entries in the table are removed 
>> before exiting. Also variables _oops_removed and _oops_counted were 
>> declared local in ResolvedMethodTable::unlink() since they are not 
>> used outside it.
>>
>> Webrev URL: http://cr.openjdk.java.net/~pchilanomate/8209844.01/webrev
>> Bug URL: https://bugs.openjdk.java.net/browse/JDK-8209844
>>
>> Thanks,
>> Patricio
>