RFR 8210168: JCK test .vm.classfmt.ins.code__002.code__00201m1.code__00201m1 hangs with -noverify
Harold David Seigel
harold.seigel at oracle.com
Thu Aug 30 13:03:54 UTC 2018
Thanks Coleen!
Harold
On 8/30/2018 8:49 AM, coleen.phillimore at oracle.com wrote:
>
> http://cr.openjdk.java.net/~hseigel/bug_8210168/webrev/src/hotspot/share/interpreter/rewriter.cpp.udiff.html
>
>
> I'm thinking this needs a better comment/message, like:
>
> + // Continuing with an invalid bytecode will fail in the loop below,
> so guarantee here. + guarantee(bc_length > 0, "The verifier should
> have caught this invalid bytecode");
>
>
> Or some more grammatical statement why guarantee. Otherwise, looks
> good and still looks trivial.
>
> Coleen
>
>
> On 8/30/18 8:36 AM, Harold David Seigel wrote:
>> Hi,
>>
>> Please review this small change to prevent the JVM from hanging when
>> running the test mentioned in the bug with -noverify.
>>
>> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8210168/webrev/
>>
>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8210168
>>
>> This fix was regression tested by running Mach5 tiers 1 and 2 tests
>> and builds on Linux-x64, Windows, and Mac OS X, running tiers 3-5
>> tests on Linux-x64, and by running JCK-11 Lang and VM tests on
>> Linux-x64. Additionally, the problematic JCK test was run with and
>> without -noverify with both fastdebug and product builds.
>>
>> Thanks, Harold
>>
>
More information about the hotspot-runtime-dev
mailing list