RFR 8206424: Use locking for cleaning ProtectionDomainTable

[Patricio Chilano]

Thanks Ioi! I'll add that comment.

Patricio


On 8/30/18 4:50 PM, Ioi Lam wrote:
> Hi Patricio,
>
> The changes look good to me. I'd suggest adding a comment. No need for 
> new webrev.
>
>       System.gc();
>       // Wait until ServiceThread cleans ProtectionDomain table.
>       // When the TestClassLoader is unloaded by GC, at least one
>       // ProtectionDomainCacheEntry will be eligible for removal.
>       do {
>         removedCount = wb.protectionDomainRemovedCount();
>       } while (removedCountOrig == removedCount);
>
> Thanks
> - Ioi
>
>
>
>
> On 8/29/2018 11:39 AM, Patricio Chilano wrote:
>> Thanks Coleen!
>>
>> Patricio
>>
>> On 8/29/18 2:33 PM, coleen.phillimore at oracle.com wrote:
>>>
>>> Looks good!
>>> Coleen
>>>
>>> On 8/29/18 1:51 PM, Patricio Chilano wrote:
>>>> Hi Ioi and Coleen,
>>>>
>>>> Could you review this new webrev that modifies test 
>>>> CleanProtectionDomain.java to protect against intermittent issues 
>>>> that might appear as seen in 8209844 ?
>>>>
>>>> Webrev URL: http://cr.openjdk.java.net/~pchilanomate/8206424.02/webrev
>>>> Bug URL: https://bugs.openjdk.java.net/browse/JDK-8206424
>>>>
>>>> Thanks,
>>>> Patricio
>>>>
>>>> On 8/21/18 5:31 PM, Patricio Chilano wrote:
>>>>> Hi Ioi and Coleen,
>>>>>
>>>>> Thanks for reviewing this change! I moved the test to 
>>>>> test/hotspot/jtreg/runtime/Dictionary and fixed the copyright. 
>>>>> Here is the new webrev:
>>>>>
>>>>> Webrev URL: 
>>>>> http://cr.openjdk.java.net/~pchilanomate/8206424.02/webrev
>>>>>
>>>>> Thanks,
>>>>> Patricio
>>>>>
>>>>> On 8/21/18 5:11 PM, coleen.phillimore at oracle.com wrote:
>>>>>>
>>>>>> Patricio,
>>>>>>
>>>>>> This looks really good.  I agree with Ioi's comment. Maybe the 
>>>>>> test could go into test/hotspot/jtreg/runtime/Dictionary (there 
>>>>>> are similar tests there?)
>>>>>>
>>>>>> Also the copyright should just have 2018 followed by a comma 
>>>>>> (even though grammatically incorrect).
>>>>>>
>>>>>> thanks,
>>>>>> Coleen
>>>>> On 8/21/18 3:27 PM, Ioi Lam wrote:
>>>>>> Hi Patricio,
>>>>>>
>>>>>> I think the test should be under a different directory since it 
>>>>>> is not specific to AppCDS
>>>>>>
>>>>>> Thanks
>>>>>> Ioi
>>>>>>
>>>>>>> On Aug 21, 2018, at 11:47 AM, Patricio Chilano 
>>>>>>> <patricio.chilano.mateo at oracle.com> wrote:
>>>>>>>
>>>>>>> Hi all,
>>>>>>> Could you review this fix that moves the cleanup of dead entries 
>>>>>>> in the protection domain table from the VMThread to the 
>>>>>>> ServiceThread.
>>>>>>> The goal is the same as JDK-8206423. The task of cleaning up 
>>>>>>> dead entries in the protection domain table was moved to the 
>>>>>>> ServiceThread.
>>>>>>> The fix was tested with Mach5 on tiers 1, 2, 3 on all platforms. 
>>>>>>> A new test 
>>>>>>> (test/hotspot/jtreg/runtime/appcds/CleanProtectionDomain.java) 
>>>>>>> was added to test the creation and removal of entries in the 
>>>>>>> Protection Domain table.
>>>>>>> Bug URL: https://bugs.openjdk.java.net/browse/JDK-820642 
>>>>>>> <https://bugs.openjdk.java.net/browse/JDK-8206423>4
>>>>>>> Webrev URL: 
>>>>>>> http://cr.openjdk.java.net/~pchilanomate/8206424.01/webrev/index.html 
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Patricio
>>>>>>>
>>>>>
>>>>
>>>
>>
>