RFR (trivial) 8214726 Typo in HeapShared::check_closed_archive_heap_region_object

Ioi Lam ioi.lam at oracle.com
Mon Dec 3 18:16:47 UTC 2018


Hi, please review this trivial fix of a missing "==". That code path is 
actually never executed today so we didn't notice the bug.

Thanks

- Ioi

diff -r 56ca125c973b src/hotspot/share/memory/heapShared.cpp
--- a/src/hotspot/share/memory/heapShared.cpp    Thu Nov 29 06:34:46 
2018 -0800
+++ b/src/hotspot/share/memory/heapShared.cpp    Mon Dec 03 10:13:48 
2018 -0800
@@ -581,7 +581,7 @@
    for (JavaFieldStream fs(k); !fs.done(); fs.next()) {
      if (!fs.access_flags().is_static()) {
        BasicType ft = fs.field_descriptor().field_type();
-      if (!fs.access_flags().is_final() && (ft == T_ARRAY || T_OBJECT)) {
+      if (!fs.access_flags().is_final() && (ft == T_ARRAY || ft == 
T_OBJECT)) {
          ResourceMark rm(THREAD);
          log_warning(cds, heap)(
            "Please check reference field in %s instance in closed 
archive heap region: %s %s",



More information about the hotspot-runtime-dev mailing list