RFR 8209387: Follow ups to JDK-8195100 Use a low latency hashtable for SymbolTable

Kim Barrett kim.barrett at oracle.com
Wed Dec 5 00:20:18 UTC 2018


> On Dec 4, 2018, at 12:39 PM, Gerard Ziemski <gerard.ziemski at oracle.com> wrote:
> 
> Thank you Kim for the review!
> 
>> On Dec 4, 2018, at 12:36 AM, Kim Barrett <kim.barrett at oracle.com> wrote:What happened to this entry in the CR:
>> 
>> src/hotspot/share/classfile/stringTable.hpp
>> 87 size_t add_items_count_to_clean(size_t ndead);
>> 
>> This name change doesn't seem right.
> 
> I changed:
> 
> add_items_count_to_clean() -> set_item_clean_count()
> 
> as part of the original work for JDK-8195100. Would you like to suggest a different name?

The name you describe is in SymbolTable.

Also as part of JDK-8195100, StringTable::add_items_to_clean() was changed to
StringTable::add_items_count_to_clean().  That is the name change that I objected to at
the time, and which is referred to by this item in the bug report.  Please revert it back to
the original name.



More information about the hotspot-runtime-dev mailing list