RFR(XS): 8214707: Prevent GCC 8 from reporting error in ClassLoader::file_name_for_class_name()

Dmitry Chuyko dmitry.chuyko at bell-sw.com
Fri Dec 7 07:51:41 UTC 2018


Thanks for the review. Pushed with size_t.

-Dmitry

On 12/7/18 4:06 AM, David Holmes wrote:
> +1
>
> Annoying to have to workaround a buggy compiler though. :(
>
> Thanks,
> David
>
> On 7/12/2018 6:44 am, Harold David Seigel wrote:
>> Hi Dmitry,
>>
>> Could you change the type of class_suffix_len from int to size_t ?
>> Otherwise, it looks good.  (I don't need to see a new webrev.)
>>
>> Thanks, Harold
>>
>>
>> On 12/6/2018 3:19 PM, Dmitry Chuyko wrote:
>>> Hello,
>>>
>>> Please review a small fix for an error reported by GCC 8. It's a 
>>> false positive and minor code clean-up silences the compiler: suffix 
>>> length is extracted into a variable.
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8214707
>>> webrev: http://cr.openjdk.java.net/~dchuyko/8214707/webrev.00/
>>> testing: submit repo 
>>> (mach5-one-dchuyko-JDK-8214707-20181206-1906-13407: PASSED)
>>>
>>> -Dmitry
>>>
>>


More information about the hotspot-runtime-dev mailing list