RFR(XS): 8215342: [Zero] Build fails after JDK-8200613

[Chris Phillips]

Looks good!

On 2018-12-13 7:44 a.m., Severin Gehwolf wrote:
> On Thu, 2018-12-13 at 13:12 +0100, Aleksey Shipilev wrote:
>> On 12/13/18 10:50 AM, Severin Gehwolf wrote:
>>> On Thu, 2018-12-13 at 10:38 +0100, Severin Gehwolf wrote:
>>>> Hi,
>>>>
>>>> Can I get reviews for this (trivial?) Zero build fix, please?
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8215342
>>>
>>> Or better yet so as to keep the symmetry of '#if INCLUDE_CDS' which
>>> is
>>> being used for implementations in class ClassLoader:
>>>
>>> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8215342/02/webrev/
>>
>> I think the other use of UseSharedSpaces should also be protected for
>> symmetry.
>>
>> +#if INCLUDE_CDS
>>    if (UseSharedSpaces && DumpPrivateMappingsInCore) {
>>      set_coredump_filter(FILE_BACKED_PVT_BIT);
>>    }
>> +#endif
> 
> Thanks. How about this?
> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8215342/03/webrev/
> 
>> (That's what I did in 
>> https://bugs.openjdk.java.net/browse/JDK-8215351)
> 
> Shall we close this one as duplicate?
> 
> Thanks,
> Severin
> 
> 
> 

Cheers!
Chris