RFR 8205505: Expire and remove remaining support for commercial features

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Mon Dec 17 21:48:12 UTC 2018


Looks good!
Coleen

On 12/17/18 4:31 PM, Harold David Seigel wrote:
> Hi David,
>
> Thanks for looking at this!
>
> I do have an updated webrev for review.  It is similar to the original 
> one except file arguments_ext.hpp is removed and file 
> configurations.xml is slightly changed.
>
> http://cr.openjdk.java.net/~hseigel/bug_8205505.2/webrev/index.html
>
> Thanks, Harold
>
>
> On 12/17/2018 2:00 AM, David Holmes wrote:
>> Correction: I now see lookup_special_flag_ext is still being used and 
>> is needed so not everything can be removed.
>>
>> But ArgumentsExt is now an empty class and unused so it and 
>> arguments_ext.hpp should be removed I think.
>>
>> Thanks,
>> David
>>
>> On 17/12/2018 11:17 am, David Holmes wrote:
>>> Hi Harold,
>>>
>>> On 15/12/2018 4:23 am, Harold David Seigel wrote:
>>>> Hi,
>>>>
>>>> Please review this updated fix for JDK-13 that is part of removing 
>>>> support for non-existing commercial features. Support was obsoleted 
>>>> in JDK-8202331 <https://bugs.openjdk.java.net/browse/JDK-8202331>.
>>>>
>>>> Open Webrev: 
>>>> http://cr.openjdk.java.net/~hseigel/bug_8205505.1/webrev/index.html
>>>
>>> AFAICS we can now get rid of the ArgumentsExt class and associated 
>>> files completely.
>>>
>>> Thanks,
>>> David
>>>
>>>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8205505
>>>>
>>>> The fix was regression tested by running Mach5 tiers 1 and 2 tests 
>>>> and builds on Linux-x64, Windows, and Mac OS X, running tiers 3-5 
>>>> tests on Linux-x64, and by running JCK-12 Lang and VM tests on 
>>>> Linux-x64.
>>>>
>>>> Thanks, Harold
>>>>
>



More information about the hotspot-runtime-dev mailing list