RFR: 8196657: [Testbug] TestOptionsWithRanges will fail for newly obsoleted flags that have not yet been removed

Kim Barrett kim.barrett at oracle.com
Fri Feb 2 11:41:05 UTC 2018


> On Feb 2, 2018, at 3:39 AM, David Holmes <david.holmes at oracle.com> wrote:
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8196657
> webrev: http://cr.openjdk.java.net/~dholmes/8196657/webrev/
> 
> TestOptionsWithRanges uses PrintFlags to get the set of flags to test, and then proceeds to give them valid and invalid values.
> 
> When we bump the JDK version and a flag is now considered obsolete (but has not yet been removed from the code) the flag is ignored (other than printing a warning) and so the tests with invalid values do not generate errors, and so those tests fail.
> 
> The fix is to simply watch for "Ignoring option xxx" in the stderr output and report success.
> 
> Pushing to jdk/jdk.
> 
> Thanks,
> David

Shouldn’t the fatal error detection case still be first?  As written, if an option is ignored but
the VM then failed to start for some reason, that will be counted as a pass.  That doesn’t
seem right.




More information about the hotspot-runtime-dev mailing list