RFR(M): 8196786: [PPC64+s390] ConstantDynamic support

[Doerr, Martin]

Hi Paul,

thank you very much for pointing me to these os.arch checks.
I've added them to the webrev (in place update).

Unfortunately, they will cause merge conflicts with the aarch64 change.
Actually, I'd have preferred failing jtreg tests over exclusions by such checks, but that's another topic.

Best regards,
Martin


-----Original Message-----
From: Paul Sandoz [mailto:paul.sandoz at oracle.com] 
Sent: Montag, 5. Februar 2018 19:38
To: Doerr, Martin <martin.doerr at sap.com>
Cc: hotspot-runtime-dev at openjdk.java.net
Subject: Re: RFR(M): 8196786: [PPC64+s390] ConstantDynamic support

Hi Martin,

Like for AArch64 changes from Dmitry i am not very qualified to review those. 

Do you need to update the jtreg metadata for test execution see Dmitry’s changes to the tests [*]:

  http://cr.openjdk.java.net/~dsamersoff/JDK-8190428/webrev.05/

Thanks,
Paul.

[*] e.g.
--- old/test/jdk/java/lang/invoke/condy/CondyRepeatFailedResolution.java	2018-02-03 12:28:15.636918584 +0000
+++ new/test/jdk/java/lang/invoke/condy/CondyRepeatFailedResolution.java	2018-02-03 12:28:14.976891877 +0000
@@ -25,7 +25,7 @@
  * @test
  * @bug 8186211
  * @summary Test basic invocation of multiple ldc's of the same dynamic constant that fail resolution
- * @requires os.arch == "x86_64"
+ * @requires os.arch == "x86_64" | os.arch=="aarch64"
  * @library /lib/testlibrary/bytecode /java/lang/invoke/common
  * @build jdk.experimental.bytecode.BasicClassBuilder
  * @run testng CondyRepeatFailedResolution



> On Feb 5, 2018, at 7:52 AM, Doerr, Martin <martin.doerr at sap.com> wrote:
> 
> Hi,
> 
> I've just implemented the template interpreter parts for ConstantDynamic support (jdk-8186046) on PPC64 and s390.
> 
> The following tests have passed on linux ppc64le + s390 and AIX:
> test/jdk/java/lang/invoke/condy/
> 
> Please review:
> http://cr.openjdk.java.net/~mdoerr/8196786_ppc64_s390_condy/webrev.00/
> 
> Best regards,
> Martin
>