RFR (XS) 8196806: Deprecate VMThreadHintNoPreempt and CompilerThreadHintNoPreempt

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Thu Feb 8 20:14:02 UTC 2018



On 2/7/18 6:56 PM, David Holmes wrote:
> Hi Coleen,
>
> On 8/02/2018 2:07 AM, coleen.phillimore at oracle.com wrote:
>> open webrev at http://cr.openjdk.java.net/~coleenp/8196806.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8196806
>
> As I put in the CSR you should switch CompilerThreadNoHintPreempt to 
> default false as part of the deprecation so that if its absence would 
> cause a problem it will be detected during the deprecation phase.

Okay, yes, I didn't realize that you suggested that.   I've changed the 
value to false and run all the tier1-5 sparc tests on the change.
>
> Otherwise this is fine (but needs to wait until the version change 
> hits jdk/hs).

The deprecation function for the table doesn't compare to the current 
version, so the test and the message still works.

busaa027.us.oracle.com% java -XX:+CompilerThreadHintNoPreempt 
-XX:+VMThreadHintNoPreempt -version
Java HotSpot(TM) 64-Bit Server VM warning: Option 
CompilerThreadHintNoPreempt was deprecated in version 11.0 and will 
likely be removed in a future release.
Java HotSpot(TM) 64-Bit Server VM warning: Option VMThreadHintNoPreempt 
was deprecated in version 11.0 and will likely be removed in a future 
release.
java version "10-internal" 2018-03-20
Java(TM) SE Runtime Environment 18.3 (fastdebug build 
10-internal+0-2018-02-08-1947218.cphillim.11preempt)
Java HotSpot(TM) 64-Bit Server VM 18.3 (fastdebug build 
10-internal+0-2018-02-08-1947218.cphillim.11preempt, mixed mode)

Thanks,
Coleen
>
> Thanks,
> David
>
>> CSR was approved.
>> thanks,
>> Coleen



More information about the hotspot-runtime-dev mailing list