RFR(L): 8197405: Improve messages of AbstractMethodErrors and IncompatibleClassChangeErrors.

David Holmes david.holmes at oracle.com
Thu Feb 8 22:53:58 UTC 2018


Hi Goetz,

Binary class files can not be checked-in to the repo. You'll need to use 
jasm or jcod files that then get compiled as part of the test.

Thanks,
David

On 9/02/2018 12:41 AM, Lindenmaier, Goetz wrote:
> Hi,
> 
> This change improves the messages of AbstractMethodErrors and IncompatibleClassChangeErrors.
> Please review.
> http://cr.openjdk.java.net/~goetz/wr18/8197405-ameExMsg/webrev.01/
> 
> It adds tests that check some of the improved messages.
> The tests check the following improvements:
> 
> AbstractMethodErrors:
> 
> test_ameInt, test case 1:
> before: no message / null
> after:  Missing implementation of interface method MyAbstractInt.anAbstractMethod()Ljava/lang/String;
> 
> test_ameInt, test case 2:
> before: no message / null
> after:  Class ImplementsSomeFunctionsInt does not implement the requested method
>          aFunctionOfMyInterface()Ljava/lang/String; inherited from interface MyInterfaceInt1
> 
> test_ame, interpreted:
> before: no message / null
> after:  Missing implementation of interface method MyInterface.aFunctionOfMyInterface()V
> 
> test_ame, compiled:
> before: MyAbstract.aFunctionOfMyInterface()V
> after:  Class ImplementsSomeFunctions does not implement the requested method
>          aFunctionOfMyInterface()V inherited from abstract class MyAbstract
> 
> IncompatibleClassChangeErrors:
> 
> test_icc_compiled_itable_stub
> before: vtable stub
> after:  Class ICC_B does not implement the requested interface ICC_iB
> 
> Best regards,
>    Goetz.
> 


More information about the hotspot-runtime-dev mailing list