RFR(S): 8194994: Remove redundant string streams used for logging

Marcus Larsson marcus.larsson at oracle.com
Mon Feb 12 11:40:10 UTC 2018


Hi Ioi,


On 2018-02-12 12:06, Ioi Lam wrote:
> Hi Marcus,
>
> Looks good. Some small nits:
>
> compactHashtable.cpp: copyright date
>
> filemap.cpp: the indentation  needs to be fixed:
>
>  414  LogMessage(cds) msg;
>  415   if (msg.is_info()) {
>  416     msg.info("Dumping shared data to file: ");
>  417     msg.info("   %s", _full_path);
>  418   }

Good catch, will fix before pushing!

Thanks for reviewing!
Marcus

>
> Thanks
> - Ioi
>
> On 2/11/18 11:13 PM, Marcus Larsson wrote:
>> Hi,
>>
>> Please review the following patch to remove some redundant uses of 
>> string streams used for logging.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~mlarsson/8194994/webrev.00/
>>
>> Issue:
>> https://bugs.openjdk.java.net/browse/JDK-8194994
>>
>> Tested with hs-tier 1-2.
>>
>> Thanks,
>> Marcus
>



More information about the hotspot-runtime-dev mailing list