RFR(XS): 8197572: s390 build broken after 8165929

[Doerr, Martin]

Hi Coleen,

I understand that and I think it's ok to push without testing on our platforms if the author feels confident and problems seem unlikely.

Building a patch on linux PPC64 or s390 is pretty quick, so if the author has any concern, we should be able to build it quickly.

Best regards,
Martin


-----Original Message-----
From: coleen.phillimore at oracle.com [mailto:coleen.phillimore at oracle.com] 
Sent: Montag, 12. Februar 2018 15:55
To: Doerr, Martin <martin.doerr at sap.com>; hotspot-runtime-dev at openjdk.java.net
Subject: Re: RFR(XS): 8197572: s390 build broken after 8165929



On 2/12/18 9:40 AM, Doerr, Martin wrote:
> Hi Coleen,
>
> no problem. Thanks for reviewing and for adapting all the other PPC64 and s390 functions.

There's sort of a fine balance of whether I should have waited to have 
pushed the change for the other platforms to run tests, but I thought it 
was unlikely to have missed anything. And I don't know how time 
consuming it is for you to drop everything and test the patch.  It was 
simple enough to fix in this case.

I would wait for a more complicated change, but let me know if I should 
wait in the future with this sort of change also.

Thanks,
Coleen


>
> Best regards,
> Martin
>
>
> -----Original Message-----
> From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of coleen.phillimore at oracle.com
> Sent: Montag, 12. Februar 2018 15:14
> To: hotspot-runtime-dev at openjdk.java.net
> Subject: Re: RFR(XS): 8197572: s390 build broken after 8165929
>
>
> This looks good.  I'm sorry, I don't know how I missed "HeapWork* from"
> since that's was the pattern I was looking for.
> thanks,
> Coleen
>
>
> On 2/12/18 8:53 AM, Thomas Stüfe wrote:
>> Looks good.
>>
>> Thanks, Thomas
>>
>> On Mon, Feb 12, 2018 at 2:51 PM, Doerr, Martin <martin.doerr at sap.com> wrote:
>>
>>> Hi,
>>>
>>> please review this tiny s390 build fix:
>>> http://cr.openjdk.java.net/~mdoerr/8165929_s390_build/webrev.00/
>>>
>>> Best regards,
>>> Martin
>>>
>>>