RFR(xs): 8198270: Remove dangerous assert in HandleArea::oops_do()

Per Liden per.liden at oracle.com
Fri Feb 16 14:36:49 UTC 2018


Thanks for reviewing Coleen!

/Per

On 02/16/2018 03:14 PM, coleen.phillimore at oracle.com wrote:
> 
> Looks good.  I think it counts as trivial and can be pushed.
> Thanks,
> Coleen
> 
> 
> On 2/16/18 8:49 AM, Per Liden wrote:
>> With the introduction of the Access API it's no longer safe to assume 
>> that you can safely de-reference an oop without using the proper 
>> Access function. The assert in HandleArea::oops_do() makes this 
>> assumption, which can lead to crashes. This patch removes the 
>> offending assert.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8198270
>> Webrev: http://cr.openjdk.java.net/~pliden/8198270/webrev.0/
>>
>> /Per
>>
> 


More information about the hotspot-runtime-dev mailing list