PING. Re: RFR (trivial): 8197827: [windows] Small cleanups after JDK-8185712

David Holmes david.holmes at oracle.com
Wed Feb 21 12:34:44 UTC 2018


On 21/02/2018 9:07 PM, Thomas Stüfe wrote:
> Could I have a second reviewer and a sponsor please?

src/hotspot/os/windows/windbghelp.hpp

Copyright year should be "2017, 2018,".

Same for src/hotspot/os/windows/symbolengine.cpp.

Otherwise Reviewed.

Send me the completed changeset and I'll sponsor it.

Thanks,
David


> Thank you, Thomas.
> 
> On Tue, Feb 13, 2018 at 3:27 PM, Thomas Stüfe <thomas.stuefe at gmail.com>
> wrote:
> 
>> Thanks Zhengyu!
>>
>> On Tue, Feb 13, 2018 at 3:17 PM, Zhengyu Gu <zgu at redhat.com> wrote:
>>
>>> Hi Thomas,
>>>
>>> Nit: Copyright year on symbolengie.cpp
>>>
>>> Otherwise, looks good.
>>>
>>> Thanks,
>>>
>>> -Zhengyu
>>>
>>>
>>> On 02/13/2018 09:05 AM, Thomas Stüfe wrote:
>>>
>>>> Hi all,
>>>>
>>>> could I have reviews and a sponsor please for this very trivial
>>>> windows-only change.
>>>>
>>>> Just a cleanup up some remnants of "JDK-8185712 [windows] Improve native
>>>> symbol decoder" - deleting an orphaned function prototype not needed
>>>> anymore, correcting include guard names and adding a missing include.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8197827
>>>> Webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8197827-cleanups-
>>>> windows/
>>>> webrev.00/webrev/
>>>>
>>>> Thanks, Thomas
>>>>
>>>>
>>


More information about the hotspot-runtime-dev mailing list