RFR (trivial) 8068593: Remove or repurpose unused PerfCounters from objectMonitor
coleen.phillimore at oracle.com
coleen.phillimore at oracle.com
Wed Feb 21 16:55:02 UTC 2018
Also, still trivial, I removed two now unused "Knobs".
open webrev at http://cr.openjdk.java.net/~coleenp/8068593.02/webrev
thanks,
Coleen
On 2/21/18 9:40 AM, coleen.phillimore at oracle.com wrote:
>
>
> On 2/21/18 9:37 AM, Claes Redestad wrote:
>> Hi,
>>
>> objectMonitor.cpp, maybe remove the now dead block?
>>
>> if (Knob_LogSpins == 0) {
>> - ObjectMonitor::_sync_FailedSpins = NULL;
>> }
>>
>> Otherwise looks good to me, but you may want a review from someone
>> less biased. :-)
>
> Yes, I do. thanks for noticing this.
>
> Coleen
>
>>
>> /Claes
>>
>>
>> On 2018-02-21 15:34, coleen.phillimore at oracle.com wrote:
>>> Just removed them and ran tier1 tests. The ones remaining are deemed
>>> useful. See bug for details.
>>>
>>> open webrev at http://cr.openjdk.java.net/~coleenp/8068593.01/webrev
>>> bug link https://bugs.openjdk.java.net/browse/JDK-8068593
>>>
>>> Thanks,
>>> Coleen
>>
>
More information about the hotspot-runtime-dev
mailing list