RFR 8194085: Obsolete the deprecated SafepointSynchronize flags and remove related code
coleen.phillimore at oracle.com
coleen.phillimore at oracle.com
Wed Feb 21 19:33:52 UTC 2018
http://cr.openjdk.java.net/~hseigel/bug_8194085/webrev/src/hotspot/share/runtime/safepoint.cpp.udiff.html
+#define SafepointSpinBeforeYield 2000
Can you make this a static const instead of #define and use
_safepoint_spin_before_yield so it doesn't look like a command line option?
The rest looks good.
Thanks,
Coleen
On 2/21/18 1:31 PM, harold seigel wrote:
> Hi,
>
> Please review this JDK-11 change to obsolete the
> SafepointSpinBeforeYield, DeferThrSuspendLoopCount, and
> DeferPollingPageLoopCount options and related code. With this change,
> these options are still accepted on the command line but have no
> affect other than to generate these warning messages:
>
> Java HotSpot(TM) 64-Bit Server VM warning: Ignoring option
> SafepointSpinBeforeYield; support was removed in 11.0
> Java HotSpot(TM) 64-Bit Server VM warning: Ignoring option
> DeferThrSuspendLoopCount; support was removed in 11.0
> Java HotSpot(TM) 64-Bit Server VM warning: Ignoring option
> DeferPollingPageLoopCount; support was removed in 11.0
>
> Open Webrev:
> http://cr.openjdk.java.net/~hseigel/bug_8194085/webrev/index.html
>
> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8194085
>
> The change was tested with Mach5 tiers 1 and 2 on all Mach5 platforms
> and tiers 3-5 in Linux-X64.
>
> Thanks, Harold
More information about the hotspot-runtime-dev
mailing list