RFR (XS): 8198560: Remove implicit casts from oop to JavaThread* and jlong*

Erik Österlund erik.osterlund at oracle.com
Thu Feb 22 20:58:01 UTC 2018


Hi Coleen,

Thanks for the review.

/Erik

On 2018-02-22 19:24, coleen.phillimore at oracle.com wrote:
> This looks really good.  Glad that our code doesn't need these hacks 
> anymore.
> Coleen
>
> On 2/22/18 11:44 AM, Erik Österlund wrote:
>> Hi,
>>
>> In the current state, oop may be implicitly casted to JavaThread* and 
>> jlong*. There does not appear to be code relying on these casts, and 
>> therefore they should be removed. In the unlikely case this operation 
>> would make sense, then you may use cast_from_oop<JavaThread*>(obj) 
>> instead.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~eosterlund/8198560/webrev.00/
>>
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8198560
>>
>> Thanks,
>> /Erik
>



More information about the hotspot-runtime-dev mailing list