RFR(S): 8193434: [GRAAL] Graal classes are not loaded with -Xshare:dump

[Vladimir Kozlov]

Hi Calvin,

I tried to run your patch with test case from bug and I got next warnings about Graal classes:

Loading classes to share: done.
[0.935s][info][cds       ] Shared spaces: preloaded 1187 classes
Rewriting and linking classes ...
Preload Warning: Verification failed for 
org.graalvm.compiler.hotspot.replacements.arraycopy.ArrayCopyNode
Preload Warning: Verification failed for 
org.graalvm.compiler.hotspot.replacements.arraycopy.ArrayCopyWithSlowPathNode

I see that Graal classes are loaded:

[0.717s][info][class,load] 
org.graalvm.compiler.hotspot.replacements.arraycopy.ArrayCopyWithSlowPathNode source: 
jrt:/jdk.internal.vm.compiler
[0.718s][info][class,load] org.graalvm.compiler.hotspot.replacements.arraycopy.ArrayCopyNode source: 
jrt:/jdk.internal.vm.compiler

Is it because CDS is limited to java.base? With UseAppCDS I don't have this problem.

Thanks,
vladimri

On 2/27/18 11:01 AM, Calvin Cheung wrote:
> bug: https://bugs.openjdk.java.net/browse/JDK-8193434
> 
> webrev: http://cr.openjdk.java.net/~ccheung/8193434/webrev.01/
> 
> java -Xshare:dump -Xlog:cds,cds+hashtables -XX:+UnlockDiagnosticVMOptions 
> -XX:SharedArchiveFile=./test.jsa -Xbatch -XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCI 
> -XX:+UseJVMCICompiler -Djvmci.Compiler=graal
> 
> The above command causes the CNFE to be thrown in SystemDictionary::resolve_from_stream() during CDS 
> dump time.
> The proposed change is to add a _force_init_jvmci_runtime flag which is set at the beginning of 
> JVMCIRuntime::force_initialization() and reset at the end of the initialization. The flag will be 
> checked in SystemDictionary::resolve_from_stream() so that it will not throw CNFE during the eager 
> initialization of JVMCI runtime during vm init.
> 
> The proposed change passed hs-tier1 through hs-tier3 testing on linux-x64, windows-x64, sparcv9, and 
> Mac OS X.
> 
> thanks,
> Calvin
>