RFR(S) 8193664 [10] - AppCDS tests should use -XX:+UnlockCommercialFeatures when running with commercial JDK

[David Holmes]

Hi Ioi,

I have two small reservations ...

1. The duplicate definitions of commercial()
2. The use of -showversion in the openJDK case. Might not this interfere 
with output parsing?

Thanks,
David

On 11/01/2018 5:47 AM, Ioi Lam wrote:
> Hi,
> 
> Please review this small change in the AppCDS tests
> 
> https://bugs.openjdk.java.net/browse/JDK-8193664
> http://cr.openjdk.java.net/~iklam/jdk10/8193664-commercial-appcds-testbug.v01/ 
> 
> 
> Summary:
> 
>      * This patch changes tests ONLY. There's no code change.
>      * The change affects ONLY the commercial JDK built by Oracle.
>      * It does not affect the OpenJDK
> 
>      * Oracle commercial JDK 10 still requires 
> -XX:+UnlockCommercialFeatures
>        to be specified when using AppCDS tests. This requirement will be
>        removed soon in the future, but meanwhile, we need to add a few
>        -XX:+UnlockCommercialFeatures flags in the test cases to make 
> them pass.
> 
> Tested under both Oracle commercial JDK and OpenJDK builds. All affected
> tests passed in both configurations.
> 
> Thanks
> - Ioi
> 
>