RFR (S) 8175249: VMThread::run fails in VerifyBeforeExit : Universe::verify

Zhengyu Gu zgu at redhat.com
Tue Jan 23 20:12:44 UTC 2018


Hi Coleen,

Looks good to me.

Thanks,

-Zhengyu

On 01/23/2018 02:56 PM, coleen.phillimore at oracle.com wrote:
> 
> Hi Zhengyu,
> 
> Thank you for finding this.  Here is the update.
> 
> open webrev at http://cr.openjdk.java.net/~coleenp/8175249.02/webrev
> 
> Thanks,
> Coleen
> 
> On 1/22/18 10:28 PM, Zhengyu Gu wrote:
>> Hi Coleen,
>>
>>  233       }
>>  234       if (probe->pd_set() == current) {
>>  235         probe->set_pd_set(current->next());
>>  236       }
>>  237       ProtectionDomainEntry* to_delete = current;
>>  238       current = current->next();
>>  239       delete to_delete;
>>  240     } else {
>>  241       current = current->next();
>>  242     }
>>
>> when probe->pd_set() != current, I think you need prev->_next = 
>> current->_next to keep linked list valid.
>>
>> Do I miss something here?
>>
>> Thanks,
>>
>> -Zhengyu
>>
>> On 01/22/2018 06:52 PM, coleen.phillimore at oracle.com wrote:
>>> Summary: protection domain package access cache needs to be walked in 
>>> unloading
>>>
>>> Tested with mach5 tier1-5 on linux and windows, and with tests in the 
>>> bug report.
>>>
>>> open webrev at http://cr.openjdk.java.net/~coleenp/8175249.01/webrev
>>> bug link https://bugs.openjdk.java.net/browse/JDK-8175249
>>>
>>> Thanks,
>>> Coleen
> 


More information about the hotspot-runtime-dev mailing list