RFR(S) [8u] 8189170: Add option to disable stack overflow checking in primordial thread for use with JNI_CreateJavaJVM

David Holmes david.holmes at oracle.com
Thu Jan 25 04:36:50 UTC 2018


Sorry David one minor nit.

In the <os>_<cpu>.cpp files where you changed is_initial_thread() to 
is_primordial_thread(), in the following comment it still says

// initial thread ...

but should now say

// primordial thread

No need to see updated webrev.

Thanks,
David

On 25/01/2018 1:42 PM, David Holmes wrote:
> Hi David,
> 
> That looks like an accurate backport of the changes. Reviewed.
> 
> Thanks,
> David
> 
> On 25/01/2018 12:50 PM, David Buck wrote:
>> Hi!
>>
>> Please review my backport of this small change to JDK 8.
>>
>> bug report:
>> https://bugs.openjdk.java.net/browse/JDK-8189170
>>
>> original JDK changeset:
>> http://hg.openjdk.java.net/jdk/jdk/rev/9fd89aabb6cd
>>
>> code review of original change:
>> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2017-November/025207.html 
>>
>>
>> JDK 8 webrev for review:
>> http://cr.openjdk.java.net/~dbuck/8189170_jdk8_ver00/
>>
>> All standard JPRT tests run and passed (hotspot testset). 
>> Effectiveness of change manually confirmed with dummy JNI invocation 
>> test case.
>>
>> Cheers,
>> -Buck


More information about the hotspot-runtime-dev mailing list