[12] RFR (S) 8202737: Obsolete AllowNonVirtualCalls option

[coleen.phillimore at oracle.com]

On 7/5/18 8:51 PM, David Holmes wrote:
> On 6/07/2018 10:25 AM, Kim Barrett wrote:
>>> On Jul 5, 2018, at 5:19 PM, coleen.phillimore at oracle.com wrote:
>>>
>>> Summary: obsolete option and remove support.
>>>
>>> open webrev at http://cr.openjdk.java.net/~coleenp/8202737.01/webrev
>>> bug link https://bugs.openjdk.java.net/browse/JDK-8202737
>>>
>>> % java -XX:-AllowNonVirtualCalls -version
>>> Java HotSpot(TM) 64-Bit Server VM warning: Ignoring option 
>>> AllowNonVirtualCalls; support was removed in 12.0
>>> java version "12-internal" 2019-03-19
>>> Java(TM) SE Runtime Environment 19.3 (fastdebug build 
>>> 12-internal+0-2018-07-05-1741563.cphillim.12remove-allow-nv)
>>> Java HotSpot(TM) 64-Bit Server VM 19.3 (fastdebug build 
>>> 12-internal+0-2018-07-05-1741563.cphillim.12remove-allow-nv, mixed 
>>> mode)
>>>
>>> Ran mach5 hs-tier1,2 and 3.
>>>
>>> Thanks,
>>> Coleen
>>
>> Comment in arguments.cpp says
>>
>>      As "deprecated" options age into "obsolete" options, move the 
>> entry into the
>>      "Obsolete Flags" section of the table.
>>
>> I don’t need another webrev for that.
>
> Yes good point. The ordering of the obsolete section also needs fixing 
> to follow the comments (order by expired-in)
>
>> I think there’s another cleanup to do there, getting rid of the 
>> expired in 12 entries.
>
> Yes - I thought there was already a placeholder issue filed for that 
> but there isn't that I can see. We do have:
>
> https://bugs.openjdk.java.net/browse/JDK-8204591
>
> for UseAppCDS which requires more than just a table update. We could 
> possibly adapt that issue to remove all expired options (which should 
> just mean updating the table for the rest).

Oh, yes, I forgot to add that removing all the expired options is a 
different issue, and should be done as it's own RFE.

thanks,
Coleen
>
> Cheers,
> David