RFR(S): 8206408: Add missing CPU/system info to vm_version_ext on PPC64

[Doerr, Martin]

Hi Gunter,

thanks for adding the missing initialization of the values.
 
I think that the unused local variables core_id, chip_id, len and src_string should better get removed.
But I don't need a new webrev for that.

Besides that, the change looks good and I can sponsor it.

Best regards,
Martin


-----Original Message-----
From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of Haug, Gunter
Sent: Freitag, 6. Juli 2018 14:51
To: hotspot-runtime-dev at openjdk.java.net
Subject: [CAUTION] RFR(S): 8206408: Add missing CPU/system info to vm_version_ext on PPC64

Hi all,

can I please have reviews and a sponsor for the following tiny fix:

https://bugs.openjdk.java.net/projects/JDK/issues/JDK-8206408
http://cr.openjdk.java.net/~ghaug/webrevs/8206408

The solution is not really accurate as there is no obvious way to detect the number of cores/slots on a PPC64 system. Anyway, it would be better to have information on the virtualization of the system. We do have a solution for that at SAP and we would be happy to adopt it to JFR and contribute it if there is any interest.

Thanks and best regards,
Gunter