RFR(S): 8206408: Add missing CPU/system info to vm_version_ext on PPC64

[Volker Simonis]

Thanks, looks good now!

Regards,
Volker


On Mon, Jul 9, 2018 at 12:31 PM, Haug, Gunter <gunter.haug at sap.com> wrote:
> Hi Martin and Volker,
>
> Thanks for your reviews! I've incorporated your suggestions in an updated version.
> To answer your question:
>
>     Is it guaranteed, that PowerArchitecturePPC64 and
>     VM_Version::_features_strings will be always initialized before they
>     are called from VM_Version_Ext::initialize_cpu_information ?
>
> Yes, it is. This is done at the very beginning of the initialization of the VM.
>
> Here is the updated webrev:
>
> http://cr.openjdk.java.net/~ghaug/webrevs/8206408.v1
>
> Maybe one of you could be so kind and push the change?
>
> Thanks,
> Gunter
>
>
> On 06.07.18, 16:15, "Volker Simonis" <volker.simonis at gmail.com> wrote:
>
>     Hi Gunter,
>
>     in general, your change looks good!
>
>     Is it guaranteed, that PowerArchitecturePPC64 and
>     VM_Version::_features_strings will be always initialized before they
>     are called from VM_Version_Ext::initialize_cpu_information ?
>
>     And finally, I'm wondering why you are using "CPU_TYPE_DESC_BUF_SIZE -
>     1" as the length argument in the first snprintf() call. Wouldn't
>     "CPU_TYPE_DESC_BUF_SIZE" be just fine like in the second call where
>     you are using "CPU_DETAILED_DESC_BUF_SIZE".
>
>     Thank you and best regards,
>     Volker
>
>
>     On Fri, Jul 6, 2018 at 2:51 PM, Haug, Gunter <gunter.haug at sap.com> wrote:
>     > Hi all,
>     >
>     > can I please have reviews and a sponsor for the following tiny fix:
>     >
>     > https://bugs.openjdk.java.net/projects/JDK/issues/JDK-8206408
>     > http://cr.openjdk.java.net/~ghaug/webrevs/8206408
>     >
>     > The solution is not really accurate as there is no obvious way to detect the number of cores/slots on a PPC64 system. Anyway, it would be better to have information on the virtualization of the system. We do have a solution for that at SAP and we would be happy to adopt it to JFR and contribute it if there is any interest.
>     >
>     > Thanks and best regards,
>     > Gunter
>     >
>
>