8206075: add assertion for unbound assembler Labels

Liu, Xin xxinliu at amazon.com
Mon Jul 9 23:31:45 UTC 2018


Hi, Community,

Could you please review this small patch?

Bug:  https://bugs.openjdk.java.net/browse/JDK-8206075
CR:  http://cr.openjdk.java.net/~phh/8206075/webrev.00/

Problem:
X86-32/64 will leave an unbound label if UseOnStackReplacement is OFF.
This patch align up x86 with other architectures.
Add an assertion to the destructor of Label. It won’t add extra overhead because C++ compiler will wipe out the destructor in release build.

Previously, hotspot cannot pass this test with assertion on x86-64.
make run-test TEST=test/hotspot/jtreg/compiler/c1/Test7090976.java

If this CR is approved, Paul Hohensee will push it.

Thanks,
--lx




More information about the hotspot-runtime-dev mailing list