RFR (S) JDK-8178712: ResourceMark may be missing inside initialize_[vi]table
Lois Foltan
lois.foltan at oracle.com
Thu Jul 12 16:55:07 UTC 2018
On 7/10/2018 4:16 PM, Ioi Lam wrote:
>
>
> On 7/10/18 1:12 PM, Lois Foltan wrote:
>> On 7/10/2018 3:55 PM, Ioi Lam wrote:
>>
>>> Hi Lois,
>>>
>>> Looks good.
>>>
>>> 905 int klassVtable::fill_in_mirandas(int initialized) {
>>> 906 ResourceMark rm(Thread::current());
>>>
>>> maybe this function can have an addition THREAD parameter? That way
>>> you can avoid calling Thread::current(), which may be expensive.
>>
>> Thanks Ioi! Good point, new webrev in case you want to see it at
>> http://cr.openjdk.java.net/~lfoltan/bug_jdk8178712.1/webrev/
>> Lois
>>
>
> Looks good. Thanks!
> - Ioi
Thanks again for the review!
Lois
>>>
>>> Thanks
>>>
>>> - Ioi
>>>
>>>
>>> On 7/10/18 10:19 AM, Lois Foltan wrote:
>>>> Please review this clean up change to correctly set ResourceMark
>>>> from within klassVtable::initialize_vtable() and
>>>> klassItable::initialize_itable() when applicable, instead of having
>>>> all instances of calls to these two methods establish a
>>>> ResourceMark unnecessarily prior to.
>>>>
>>>> open webrev at http://cr.openjdk.java.net/~lfoltan/bug_jdk8178712/
>>>> bug link at https://bugs.openjdk.java.net/browse/JDK-8178712
>>>>
>>>> Testing: hs-tier1-3, jdk-tier1-3 (complete)
>>>> hs-tier4-5 (in progress)
>>>>
>>>> Thanks,
>>>> Lois
>>>
>>
>
More information about the hotspot-runtime-dev
mailing list