RFR(S): 8207342: error occurred during error reporting (printing register info)

[Doerr, Martin]

Hi Coleen,

thanks for the review. Pushed.

Best regards,
Martin


-----Original Message-----
From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of coleen.phillimore at oracle.com
Sent: Dienstag, 17. Juli 2018 16:11
To: hotspot-runtime-dev at openjdk.java.net
Subject: Re: RFR(S): 8207342: error occurred during error reporting (printing register info)


This looks really good, helpful, and worth having in jdk11.
Thanks,
Coleen

On 7/16/18 10:06 AM, Doerr, Martin wrote:
> Hi,
>
> I'd like to fix the "printing register info" step in hs_err files for jdk11 if possible.
>
> The function os::print_location misses a check if the pointer is readable.
> For example "jdk/bin/java -XX:+CrashGCForDumpingJavaThread -version" generates a hs_err file which doesn't analyze the registers correctly because of "error occurred during error reporting (printing register info)" in section "Register to memory mapping".
>
> In addition, registers are missing on PPC64 and s390.
>
> My proposal looks a little larger than S, but it's small besides moving the duplicated "is_readable_pointer" from codeHeapState and misc_aix to os:
> http://cr.openjdk.java.net/~mdoerr/8207342_register_info/webrev.00/
>
> Please review.
>
> Best regards,
> Martin
>