[aarch64-port-dev ] RFR: 8207838: AArch64: fix the order in which float registers are restored in restore_args

Yangfei (Felix) felix.yang at huawei.com
Mon Jul 23 08:46:19 UTC 2018


Hi, 

    Thanks for reviewing.  We plan to integrate the new test into an existing jtreg test: test/hotspot/jtreg/compiler/floatingpoint/TestFloatJNIArgs.java  
    This jtreg test did something similar, but for non-synchronized JNI method.  What do you think?  

Thanks,
Felix


> 
> On 07/19/2018 08:39 AM, Yangfei (Felix) wrote:
> >     Is it OK for jdk/jdk11?
> 
> Great catch!  That bug was committed by me on on Tue Apr 30 2013,
> which makes it more than five years old.  I think that's a record for
> AArch64.
> 
> I like the patch, but I think it'll need a proper jtreg test case.
> It's useful to test the slow JNI locking path on all arches, not just
> AArch64.
> 
> You can make the test case fail more reliably by increasing the
> contention like this:
> 
>     public void run() {
>     for (int i = 0; i < 1000; i++) {
>         float d = JniStaticContextFloat.staticMethodFloat1((float) (1), (float) (2),
> (float) (4), (float) (8));
>     }
> 
> 
> Thanks.
> 
> --
> Andrew Haley
> Java Platform Lead Engineer
> Red Hat UK Ltd. <https://www.redhat.com>
> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671


More information about the hotspot-runtime-dev mailing list