PPC64: jfr profiling doesn't work (PPC64 only)

Haug, Gunter gunter.haug at sap.com
Mon Jul 23 10:07:19 UTC 2018


Hi Goetz,

Thanks for taking the time looking into this.

>    I think instead of JavaThread::stack_red_zone_size() + JavaThread::stack_yellow_zone_size()
>    you should use  JavaThread::stack_red_zone_size() + JavaThread::stack_yellow_reserved_zone_size()

You are absolutely correct here, I missed this.

The formal stuff: I'll fix that. The empty if was an artefact, as you might have guessed, sorry.

Thanks again,
Gunter

On 20.07.18, 10:24, "Lindenmaier, Goetz" <goetz.lindenmaier at sap.com> wrote:

    Hi Gunter, 
    
    thanks for fixing these issues.
    
    frame_ppc.cpp:
    I think instead of JavaThread::stack_red_zone_size() + JavaThread::stack_yellow_zone_size()
    you should use  JavaThread::stack_red_zone_size() + JavaThread::stack_yellow_reserved_zone_size()
    
    Minor stuff:
    Please add RFR(S): <bugid> to the Subject of your mail. 
    Also, ususally the bug title is prefixed with [ppc].
    
    Please remove redundant spaces from code like 
      address   sp = (address)_sp;
     (fp <= thread->stack_base()) &&  (fp > sp)
    as well as double newlines.
    
    No space before ) please:
      if (_cb != NULL ) {
    
    Also please break some of the comments to shorter 
    lines.
    
    thread_linux_ppc.cpp
    also just minor stuff:
      Please fix indentations.  Please indent by two with spaces, no tabs.
    
      There is an empty if (ProfileInterpreter) { }. Why?
    
    I can sponsor this for you.
    
    Best regards,
      Goetz.
    
    
    > -----Original Message-----
    > From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-
    > bounces at openjdk.java.net] On Behalf Of Haug, Gunter
    > Sent: Donnerstag, 19. Juli 2018 12:53
    > To: hotspot-runtime-dev at openjdk.java.net
    > Subject: [CAUTION] PPC64: jfr profiling doesn't work (PPC64 only)
    > 
    > Hi all,
    > 
    > can I please have reviews and a sponsor for the following fix:
    > 
    > https://bugs.openjdk.java.net/projects/JDK/issues/JDK-
    > 8207392?filter=allopenissues
    > http://cr.openjdk.java.net/~ghaug/webrevs/8207392/
    > 
    > JFR profiling on linux PPC64 has not been implemented correctly so far, the
    > VM crashes when it is turned on. Therefore
    > hotspot/jtreg/runtime/appcds/TestWithProfiler.java fails. With this fix the
    > test succeeds. I've analyzed a couple of benchmarks with JMC and results
    > look plausible when compared to linux x86.
    > 
    > Thanks and best regards,
    > Gunter
    > 
    > 
    > 
    > 
    
    



More information about the hotspot-runtime-dev mailing list