RFR:8189762: [TESTBUG] Create tests for JDK-8146115 container awareness and resource configuration

[mikhailo]

The changes look good to me,

Misha


On 07/19/2018 11:45 AM, Bob Vandette wrote:
> Could you try to ask Misha to review these changes (mikhailo.seledtsov at oracle.com <mailto:mikhailo.seledtsov at oracle.com>)
> since he wrote these tests?
>
> It would be helpful to have a webrev comparing the JDK11 test sources against yours.
>
> In JDK 10, we are using @requires docker.support.  Is this not possible in JDK8?
>
> There have been a few fixes to the docker tests in JDK 11.  You should make sure to get the
> latest versions of these tests.
>
> We have also re-worked some of these tests during the addition of the Container Metrics
> API and associated tests in JDK 11 to move out common utility classes.
>
> I try to add the “docker” label to any tests and improvements related to cgroups or docker.
> Here’s a query for JDK11 AND Label == docker.
>
> https://bugs.openjdk.java.net/issues/?filter=33939&jql=project%20%3D%20JDK%20AND%20fixVersion%20%3D%20%2211%22%20AND%20labels%20%3D%20docker%20ORDER%20BY%20priority%20DESC <https://bugs.openjdk.java.net/issues/?filter=33939&jql=project%20=%20JDK%20AND%20fixVersion%20=%20%2211%22%20AND%20labels%20=%20docker%20ORDER%20BY%20priority%20DESC>
>
> Bob.
>
>
>> On Jul 17, 2018, at 10:31 AM, Vaibhav Choudhary <vaibhav.x.choudhary at oracle.com> wrote:
>>
>> Hi,
>>
>> Please review the following backport test enhancement for JDK8u written for container awareness.
>> Webrev : http://cr.openjdk.java.net/~rpatil/8189762/webrev.00/ <http://cr.openjdk.java.net/~rpatil/8189762/webrev.00/>
>>
>> Bug https://bugs.openjdk.java.net/browse/JDK-8189762 <https://bugs.openjdk.java.net/browse/JDK-8189762>
>> [TESTBUG] Create tests for JDK-8146115 container awareness and resource configuration
>>
>> Its a backport from JDK10.
>>
>> JDK10 changeset: http://hg.openjdk.java.net/jdk/jdk/rev/d6d00f785f39 <http://hg.openjdk.java.net/jdk/jdk/rev/d6d00f785f39>
>> JDK10 review thread : http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2017-November/025086.html <http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2017-November/025086.html>
>>
>> Description: Tests are very similar to JDK10, but differs in logging mechanism. -XX options like UseContainerSupport, PrintContainerInfo has been used in place of -Xlog. Few changes has been done in the Util files to make the test compatible.
>>
>> Testing: Testing has been done on Ubuntu with and without Docker environment.
>>
>> Thanks,
>> Vaibhav C