RFR 8171157: Convert ObjectMonitor_test to GTest
patricio.chilano.mateo at oracle.com
patricio.chilano.mateo at oracle.com
Wed Jul 25 20:27:51 UTC 2018
Thanks Dan!
Patricio
On 7/25/18 4:15 PM, Daniel D. Daugherty wrote:
> On 7/25/18 3:45 PM, patricio.chilano.mateo at oracle.com wrote:
>> Hi all,
>>
>> Could you please review this change? It’s a migration of the
>> ObjectMonitor test to GTest. Two GTests were actually created, one
>> for ObjectMonitor and one for ObjectSynchronizer.
>>
>> Summary:Convert ObjectMonitor_test to GTest
>>
>> Bug URL: https://bugs.openjdk.java.net/browse/JDK-8171157
>> Webrev URL:
>> http://cr.openjdk.java.net/~dcubed/for_patricio/8171157.01/webrev/
>> <http://cr.openjdk.java.net/%7Edcubed/for_patricio/8171157.01/webrev/>
>
> src/hotspot/share/runtime/objectMonitor.cpp
> No comments.
>
> src/hotspot/share/runtime/objectMonitor.hpp
> No comments.
>
> src/hotspot/share/runtime/synchronizer.cpp
> No comments.
>
> src/hotspot/share/runtime/synchronizer.hpp
> No comments.
>
> src/hotspot/share/utilities/internalVMTests.cpp
> No comments.
>
> test/hotspot/gtest/runtime/test_objectMonitor.cpp
> No comments.
>
> test/hotspot/gtest/runtime/test_synchronizer.cpp
> No comments.
>
> Thumbs up.
>
> Dan
>
>
>>
>> The fix was tested with Mach5 on tiers 1- 3 on all platforms.
>>
>> Thanks,
>> Patricio
>
More information about the hotspot-runtime-dev
mailing list