RFR 8208399: Metadata methods print_(value_)on_maybe_null() compare 'this' to NULL

Lois Foltan lois.foltan at oracle.com
Mon Jul 30 14:01:35 UTC 2018


Looks good.
Lois

On 7/27/2018 1:15 PM, Harold David Seigel wrote:
> Hi,
>
> Please review this JDK-12 fix for bug JDK-8208399.  The fix changes 
> function print_value_on_maybe_null() into a static function to avoid 
> comparisons between 'this' and NULL.  It also deletes unused methods 
> print_maybe_null() and print_on_maybe_null().
>
> Open Webrev: 
> http://cr.openjdk.java.net/~hseigel/bug_8208399/webrev/index.html
>
> JBS Bug:  https://bugs.openjdk.java.net/browse/JDK-8208399
>
> This fix was regression tested by running Mach5 tiers 1 and 2 tests 
> and builds on Linux-X64, Windows, Solaris Sparc, and Mac OS X, running 
> tiers 3-5 tests on Linux-x64, and by running JCK-11 Lang and VM tests 
> on Linux-x64.
>
> Thanks, Harold
>



More information about the hotspot-runtime-dev mailing list