[12] RFR: 8208499 NMT: Missing memory tag for Safepoint polling page
Aleksey Shipilev
shade at redhat.com
Mon Jul 30 15:05:16 UTC 2018
On 07/30/2018 04:58 PM, Zhengyu Gu wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8208499
> Webrev: http://cr.openjdk.java.net/~zgu/8208499/webrev.00/index.html
*) memory/allocation.hpp, is it really necessary to drop values from enum?
*) services/memTracker.cpp, not sure why you need to assert this:
54 // memory type occupies a byte
55 STATIC_ASSERT(mt_number_of_types <= max_jubyte);
*) runtime/NMT/SafepointPollingPages.java, excess newline:
48
49
Otherwise looks good.
-Aleksey
More information about the hotspot-runtime-dev
mailing list