RFR 8204620: ModuleEntry::is_non_jdk_module() determination for what is a jdk module is incorrect

mandy chung mandy.chung at oracle.com
Wed Jun 13 16:08:41 UTC 2018



On 6/13/18 5:44 AM, Harold David Seigel wrote:
> Hi,
> 
> Please review this fix for how the JVM determines when to print a 
> module's version.  The fix implements the refinement described in the 
> bug's comment on 12-Jun-2018.
> 
> This method is currently only called from ClassCastExceptions but will 
> be used for other messages as part of JDK-8166633 
> <https://bugs.openjdk.java.net/browse/JDK-8166633>.
> 
> Open Webrev: 
> http://javaweb.us.oracle.com/~hseigel/webrev/bug_8204620/webrev/index.html

Looks good, Harold.  I like Lois's suggestion to rename the method to 
show_version().

Mandy


More information about the hotspot-runtime-dev mailing list