[8u] RFR: 8150688: Fix os_windows siglabel

[Kevin Walls]

Thanks Kim, David.

Ah yes, the extra , was in the ia64 case, so hadn't been uncovered by 
testing.

Thanks
Kevin


On 19/06/2018 03:07, David Holmes wrote:
> Other than the stray comma looks fine.
>
> Reviewed.
>
> Thanks,
> David
>
> On 19/06/2018 9:42 AM, Kim Barrett wrote:
>>> On Jun 15, 2018, at 11:41 AM, Kevin Walls <kevin.walls at oracle.com> 
>>> wrote:
>>>
>>> Hi,
>>>
>>> I'd like to get a review of this backport from 9 to 8u:
>>>
>>> 8150688: Fix os_windows siglabel
>>> JBS:https://bugs.openjdk.java.net/browse/JDK-8150688
>>>
>>> 9 changeset:
>>> URL:http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/80706cc25494
>>>
>>> 9 review thread:
>>> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-March/018236.html 
>>>
>>>
>>> Proposed 8u 
>>> change:http://cr.openjdk.java.net/~kevinw/8150688/webrev.00/
>>
>> 2228     , def_excpt(EXCEPTION_REG_NAT_CONSUMPTION),
>>
>> stray trailing comma.
>>
>> Otherwise, looks good.  But note that I am not a JDK 8 reviewer (or 
>> even committer).
>>
>>> This is a pretty clean backport. but didn't import automatically: in 8u
>>> there is no "os::get_signal_number()" and some of the def_excpt... 
>>> lines
>>> didn't apply automatically, but they are the same change.
>>>
>>> This removes some errors when varying the windows compiler in use, 
>>> still
>>> builds and tests OK on current standard VS compiler.
>>>
>>> Thanks!
>>> Kevin
>>
>>