[aarch64-port-dev ] 8153107: Unbalanced recursive locking

Daniel D. Daugherty daniel.daugherty at oracle.com
Tue Jun 19 17:42:08 UTC 2018


Pushed the following changeset:

$ hg log -v -r tip
changeset:   50666:3e66d204af9b
tag:         tip
user:        apetushkov
date:        Fri Jun 15 13:57:32 2018 -0400
files:       src/hotspot/cpu/arm/macroAssembler_arm.cpp 
src/hotspot/share/runtime/sharedRuntime.cpp
description:
8153107: enabling ObjectSynchronizer::quick_enter() on ARM64 causes hangs
Summary: Always set the markword for recursive monitors in 
MacroAssembler::fast_lock().
Reviewed-by: aph, drwhite, dcubed, bulasevich


Andrey, thanks for fixing this (longstanding) bug!

Dan


On 6/19/18 1:32 PM, Daniel D. Daugherty wrote:
> Boris,
>
> Thanks for the testing and, based on what you wrote below, I will add
> you as a reviewer.
>
> I'll take care of pushing the fix shortly.
>
> Dan
>
>
> On 6/19/18 1:30 PM, Boris Ulasevich wrote:
>> Hi all,
>>
>>   I ran the test in different modes (single/multiple run, 
>> debug/release, Xcomp/mixed), but I can NOT reproduce the issue with 
>> current ARM32 jdk-jdk trunk. The test works Ok, as well as other 
>> jtreg runtime tests I have run today - both with and without the change.
>>
>>   The change itself looks reasonable. Andrey, I think you can commit 
>> it, and I will take care of the issue if something will go wrong.
>>
>> best regards,
>> Boris
>>
>>
>> On 19.06.2018 13:26, Andrey Petushkov wrote:
>>> Ah, I see. Looks like Bell-sw is the only company besides Oracle which
>>> works with arm(32) port (at least in the open) so it make sense for 
>>> them to
>>> make their testing
>>>
>>> Thanks for letting me know
>>>
>>> Regards,
>>> Andrey
>>>
>>> On Mon, Jun 18, 2018 at 11:31 PM Daniel D. Daugherty <
>>> daniel.daugherty at oracle.com> wrote:
>>>
>>>> Thanks Derek and Andrey!
>>>>
>>>> aleksei.voitylov at bell-sw.com sent me mail letting me know that
>>>> boris.ulasevich at bell-sw.com is doing some testing on the change
>>>> on ARM32 and will let me know the results tomorrow.
>>>>
>>>> Dan
>>>>
>>>>
>>>> On 6/18/18 4:04 PM, Andrey Petushkov wrote:
>>>>
>>>> Sure,  me too
>>>>
>>>> Thank you,
>>>> Andrey
>>>>
>>>> On Mon, Jun 18, 2018, 22:53 White, Derek <Derek.White at cavium.com> 
>>>> wrote:
>>>>
>>>>> Yes, It's a go for me on aarch64.
>>>>>
>>>>>   - Derek
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: aarch64-port-dev [mailto:aarch64-port-dev-
>>>>>> bounces at openjdk.java.net] On Behalf Of Daniel D. Daugherty
>>>>>> Sent: Monday, June 18, 2018 2:34 PM
>>>>>> To: Andrew Haley <aph at redhat.com>; Andrey Petushkov
>>>>>> <andrey.petushkov at gmail.com>
>>>>>> Cc: aarch64-port-dev at openjdk.java.net; hotspot-runtime-
>>>>>> dev at openjdk.java.net; AArch32 Port Project <aarch32-port-
>>>>>> dev at openjdk.java.net>
>>>>>> Subject: Re: [aarch64-port-dev ] 8153107: Unbalanced recursive 
>>>>>> locking
>>>>>>
>>>>>> External Email
>>>>>>
>>>>>> Greetings,
>>>>>>
>>>>>> OK so I'm not going to get a "go" based on reproducible test 
>>>>>> results.
>>>>>> I'm okay with that as long as I get a "go" from the other folks
>>>>> reviewing and
>>>>>> discussing this change:
>>>>>>
>>>>>> Andrew Haley     - go (as stated below)
>>>>>> Andrey Petushkov -
>>>>>> Dan Daugherty    - go (since Oracle platform testing passed)
>>>>>> Derek White      -
>>>>>>
>>>>>> Of course, I could have listed Andrey as a go since he is the 
>>>>>> author of
>>>>> the fix,
>>>>>> but I didn't want to assume... :-)
>>>>>>
>>>>>> Dan
>>>>>>
>>>>>>
>>>>>> On 6/18/18 12:07 PM, Andrew Haley wrote:
>>>>>>> On 06/18/2018 05:02 PM, Andrey Petushkov wrote:
>>>>>>>> And as I said, I have a reproducer. It just happen that it only
>>>>>>>> reproduces the problem on port-aarch32 implementation
>>>>>>> Well, I'm sure that I can't reproduce the problem either, and I
>>>>>>> believe that the bug does not exist on AArch64.  I'm happy for your
>>>>>>> patch to be committed.
>>>>>>>
>>>>>
>>>>>
>>>>
>
>



More information about the hotspot-runtime-dev mailing list