RFR(M): 8199940: Print more information about class loaders in IllegalAccessErrors.

Lois Foltan lois.foltan at oracle.com
Wed Jun 27 12:35:54 UTC 2018


Looks good.
Lois

On 6/27/2018 8:04 AM, Lindenmaier, Goetz wrote:
> Hi,
>
> I had to adapt some recently added tests to get this through jdk/submit:
> http://cr.openjdk.java.net/~goetz/wr18/8199940-exMsg-IllegalAccess/06/
>
> Best regards,
>    Goetz.
>
>> -----Original Message-----
>> From: Lindenmaier, Goetz
>> Sent: Dienstag, 26. Juni 2018 22:01
>> To: 'mandy chung' <mandy.chung at oracle.com>; 'Lois Foltan'
>> <lois.foltan at oracle.com>
>> Cc: hotspot-runtime-dev at openjdk.java.net
>> Subject: RE: RFR(M): 8199940: Print more information about class loaders in
>> IllegalAccessErrors.
>>
>> Hi,
>>
>> I did the small test fixes:
>> http://cr.openjdk.java.net/~goetz/wr18/8199940-exMsg-IllegalAccess/05/
>>
>> Also, I pushed it to jdk-submit.
>>
>> Best regards,
>>    Goetz
>>
>>> -----Original Message-----
>>> From: mandy chung <mandy.chung at oracle.com>
>>> Sent: Tuesday, June 26, 2018 4:55 PM
>>> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; 'Lois Foltan'
>>> <lois.foltan at oracle.com>
>>> Cc: hotspot-runtime-dev at openjdk.java.net
>>> Subject: Re: RFR(M): 8199940: Print more information about class loaders in
>>> IllegalAccessErrors.
>>>
>>>
>>>
>>> On 6/26/18 7:34 AM, Lindenmaier, Goetz wrote:
>>>> Hi,
>>>>
>>>> I updated the change to use Lois' latest change.
>>>> http://cr.openjdk.java.net/~goetz/wr18/8199940-exMsg-
>> IllegalAccess/04/
>>> Looks good.
>>>
>>> A couple of suggestions for the test:
>>>
>>> IAE_Loader1.java - you can use InputStream::readAllBytes instead of
>>> InputStream::read
>>>
>>>     79         this.notLoadable = new HashSet<>(Arrays.asList(notLoadable));
>>>
>>> Alternatively, this.notLoadable =
>>> Arrays.stream(notLoadable).collect(Collectors.toSet());
>>>
>>> Mandy



More information about the hotspot-runtime-dev mailing list