RFR(XXS) 8198845: Missing resource mark results disassembling generated code failure in hs error report

[Zhengyu Gu]

Thanks for reviewing, Thomas.

-Zhengyu

On 03/03/2018 01:08 PM, Thomas Stüfe wrote:
> +1 from me too.
> 
> Note that at worst an "Error during error reporting" could have happened 
> in the first version of your patch with thread==NULL. Resulting in a 
> skipped error reporting step. But your second patch with David 
> suggestions in it is cleaner and better documented.
> 
> Best Regards, Thomas
> 
> 
> On Fri, Mar 2, 2018 at 3:04 PM, Zhengyu Gu <zgu at redhat.com 
> <mailto:zgu at redhat.com>> wrote:
> 
>     Hi David,
> 
> 
>             Yes, it is problematic. However, it does not seem to can
>             make it worse - without resource mark, it certainly fails.
> 
>             Any suggestions?
> 
> 
>         Does it make sense to at least check we have a _thread and skip
>         that whole path if we don't? That at least addresses one concern.
> 
> 
>     Thanks for the suggestion. I narrowed scope to nmethod only, since I
>     could not find resource memory usage in interpreter and stub paths.
> 
>     Updated webrev: http://cr.openjdk.java.net/~zgu/8198845/webrev.01/
>     <http://cr.openjdk.java.net/~zgu/8198845/webrev.01/>
> 
>     -Zhengyu
> 
> 
> 
>         Thanks,
>         David
> 
>             Thanks,
> 
>             -Zhengyu
> 
>                 David
> 
>                     Test:
> 
>                         hotspot_runtime on Linux x64 (fastdebug + release)
> 
>                     Thanks,
> 
>                     -Zhengyu
> 
>