RFR(XXS) 8198845: Missing resource mark results disassembling generated code failure in hs error report

[Zhengyu Gu]

Hi David,

Thanks for reviewing.

On 03/04/2018 06:14 PM, David Holmes wrote:
> On 3/03/2018 12:04 AM, Zhengyu Gu wrote:
>> Hi David,
>>
>>>>
>>>> Yes, it is problematic. However, it does not seem to can make it 
>>>> worse - without resource mark, it certainly fails.
>>>>
>>>> Any suggestions?
>>>
>>> Does it make sense to at least check we have a _thread and skip that 
>>> whole path if we don't? That at least addresses one concern.
>>
>> Thanks for the suggestion. I narrowed scope to nmethod only, since I 
>> could not find resource memory usage in interpreter and stub paths.
>>
>> Updated webrev: http://cr.openjdk.java.net/~zgu/8198845/webrev.01/
> 
> Thanks. You should now be able to use
> 
> 780              ResourceMark rm(_thread);

Updated accordingly.

Webrev: http://cr.openjdk.java.net/~zgu/8198845/webrev.02/

Can you sponsor this change?

-Zhengyu

> 
> David
> -----
> 
>> -Zhengyu
>>
>>>
>>> Thanks,
>>> David
>>>
>>>> Thanks,
>>>>
>>>> -Zhengyu
>>>>
>>>>> David
>>>>>
>>>>>> Test:
>>>>>>
>>>>>>    hotspot_runtime on Linux x64 (fastdebug + release)
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> -Zhengyu