RFR (trivial) 8199137: StringInternSync test crashes in exit verification

[coleen.phillimore at oracle.com]

On 3/6/18 5:20 PM, David Holmes wrote:
> Hi Coleen,
>
> On 7/03/2018 6:10 AM, coleen.phillimore at oracle.com wrote:
>> Summary: java_lang_String::equals(oop, oop) was buggy.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8199137.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8199137
>
> Fix looks good but I have to wonder how this was not found before. Why 
> doesn't passing the value array oop to length() cause a crash or 
> assertion failure? What length would actually be returned in that case ??

It was causing an assertion failure that typeArrayOop was not an 
instance of java_lang_String.   This wasn't found because we never use 
this verification option.  Also since it's verify before exit, the one 
test that uses it didn't report the failure.

thanks,
Coleen
>
> Thanks,
> David
>
>> This verification is rarely called, but was called for one of the 
>> internal tests, which produced this crash.  I think Erik Osterlund 
>> found this bug at one point too.
>>
>> Thanks,
>> Coleen