RFR: 8199319: Remove handles.inline.hpp include from reflectionUtils.hpp

harold seigel harold.seigel at oracle.com
Thu Mar 8 14:46:00 UTC 2018


Hi Stefan,

The change looks good.

Thanks, Harold


On 3/8/2018 8:59 AM, Stefan Karlsson wrote:
> I've now added include lines for handles.inline.hpp where needed:
>
> http://cr.openjdk.java.net/~stefank/8199319/webrev.02.delta
> http://cr.openjdk.java.net/~stefank/8199319/webrev.02
>
> The patch is a bit larger, but I still consider it trivial.
>
> Thanks,
> StefanK
>
> On 2018-03-08 10:36, Stefan Karlsson wrote:
>> Further testing on this with other build targets show that I need to 
>> add handles.inline.hpp includes to cpp files that used to get it 
>> included from reflectionUtils.hpp. I'll post a new webrev when I've 
>> run all build targets.
>>
>> StefanK
>>
>> On 2018-03-08 10:14, Stefan Karlsson wrote:
>>> Hi all,
>>>
>>> Please review this tiny patch to remove an unnecessary include of 
>>> handles.inline.hpp. This is a step towards getting cleaner include 
>>> dependencies.
>>>
>>> http://cr.openjdk.java.net/~stefank/8199319/webrev.01/
>>>
>>> I compiled this with gcc -E to look for indirect includes of 
>>> .inline.hpp files. While doing this I found that this file couldn't 
>>> be compiled stand-alone. So, I also added the missing 
>>> growableArray.hpp include.
>>>
>>> Thanks,
>>> StefanK
>>
>>
>



More information about the hotspot-runtime-dev mailing list