RFR(S): 8199532: AbstractMethodErrorTest.java test failed with -Xcomp

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Wed Mar 14 14:53:25 UTC 2018


Hi,

this webrev adds @requires statements so that the test is skipped in the 
test runs below. With C1 the explicit compilation won't work, anyways.

Please review:
http://cr.openjdk.java.net/~goetz/wr18/8199532-fixAmeExMsg/webrev.02/

Best regards,
  Goetz.


> -----Original Message-----
> From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-
> bounces at openjdk.java.net] On Behalf Of David Holmes
> Sent: Mittwoch, 14. März 2018 01:10
> To: Vladimir Kozlov <vladimir.kozlov at oracle.com>; hotspot-runtime-
> dev at openjdk.java.net
> Subject: Re: RFR(S): 8199532: AbstractMethodErrorTest.java test failed with -
> Xcomp
> 
> On 14/03/2018 7:41 AM, Vladimir Kozlov wrote:
> > Thank you, Goetz
> >
> > -Xcomp passed now.
> >
> > I tried other flags we use for testing. And it failed when Tiered is
> > off: -XX:-TieredCompilation or -XX:+TieredCompilation
> > -XX:TieredStopAtLevel=1.
> >
> > Stupid question. Why we have different messages for compiler and
> > interpreter? The problem is the same.
> 
> The difference is whether information on the receiver class is available.
> 
> David
> 
> > -Xcomp flag also set -Xbatch flag so you don't need it in comment:
> >
> > +    // Seen if test started with -Xcomp -Xbatch:
> >
> > Thanks,
> > Vladimir
> >
> > On 3/13/18 2:14 PM, Lindenmaier, Goetz wrote:
> >> Hi,
> >>
> >> AbstractMethodErrorTest fails with -Xcomp because
> >> other exception messages are printed if the error happens
> >> in comiled code.
> >> I hardened the test.
> >> Please review:
> >> http://cr.openjdk.java.net/~goetz/wr18/8199532-
> fixAmeExMsg/webrev.01/
> >>
> >> Best regards,
> >>    Goetz.
> >>


More information about the hotspot-runtime-dev mailing list