RFR(s): 8191101: Show register content in hs-err file on assert (second version)

Andrew Dinn adinn at redhat.com
Wed Mar 21 14:22:48 UTC 2018


Hi Thomas,

On 20/03/18 14:12, Thomas Stüfe wrote:
> May I please have reviews for this new version of this RFE.
> 
> Bug id:  https://bugs.openjdk.java.net/browse/JDK-8191101
> webrev:
> http://cr.openjdk.java.net/~stuefe/webrevs/8191101-show-registers-on-assert/webrev.02/webrev/
Just a partial review for AArch64:

The AArch64 code changes look fine.
The patched code builds and runs basic programs ok.
The supplied unit test passes.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander


More information about the hotspot-runtime-dev mailing list